Skip to content

Conversation

@xeniagda
Copy link

Attempts to solve #9

Escaping is always hard to get 100% in all edge cases. This PR should handle escapes properly inside Texts and attribute values. I'm not sure whether attribute keys can be escaped, so they aren't handled. <script> and <style> are respected in that entities inside them aren't decoded in parsing nor encoded in Htmlification. Some tests have been added.

As this is a breaking change, the version should probably be bumped to 0.6 before merging.

@lomirus lomirus self-requested a review April 19, 2023 16:34
@lomirus
Copy link
Owner

lomirus commented Apr 19, 2023

Thanks for your work. I will probably review this PR in weekend.

As this is a breaking change, the version should probably be bumped to 0.6 before merging.

I would like to merge this PR as the last main update of 0.6 and then publish the v0.6 if nothing expected.

@xeniagda
Copy link
Author

:)

I'm thinking of making another PR to improve error handling in the parsing (removing anything which may panic, replacing string error messages with enums and adding source location information to some components). I think it would be nice if that could make it into the 0.6 release, but that's up to you :)

@xeniagda
Copy link
Author

Added some light documentation for the Node::Text variant reflecting this change.

@lomirus
Copy link
Owner

lomirus commented Apr 22, 2023

I'm thinking of making another PR to improve error handling in the parsing

I just published the v0.6.0 since you have made more PRs. This PR may be merged into the next version.

@xeniagda
Copy link
Author

Everything should be resolved.

@lomirus
Copy link
Owner

lomirus commented Apr 27, 2023

The conflicts need to be resolved.

@lomirus
Copy link
Owner

lomirus commented May 9, 2023

Can you fix the errors in the CI check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants