-
Notifications
You must be signed in to change notification settings - Fork 5
Encode and decode HTML escape codes #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your work. I will probably review this PR in weekend.
I would like to merge this PR as the last main update of 0.6 and then publish the v0.6 if nothing expected. |
|
:) I'm thinking of making another PR to improve error handling in the parsing (removing anything which may panic, replacing string error messages with enums and adding source location information to some components). I think it would be nice if that could make it into the 0.6 release, but that's up to you :) |
|
Added some light documentation for the Node::Text variant reflecting this change. |
I just published the v0.6.0 since you have made more PRs. This PR may be merged into the next version. |
|
Everything should be resolved. |
|
The conflicts need to be resolved. |
|
Can you fix the errors in the CI check? |
Attempts to solve #9
Escaping is always hard to get 100% in all edge cases. This PR should handle escapes properly inside
Texts and attribute values. I'm not sure whether attribute keys can be escaped, so they aren't handled.<script>and<style>are respected in that entities inside them aren't decoded in parsing nor encoded in Htmlification. Some tests have been added.As this is a breaking change, the version should probably be bumped to 0.6 before merging.