Skip to content

fix: ensure execution permissions using fs-extra #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lotharking merged 3 commits into from
Apr 21, 2025
Merged

fix: ensure execution permissions using fs-extra #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d09b6ea
ci: update
lotharking Apr 21, 2025
13dcf00
fix: ensure execution permissions using fs-extra
lotharking Apr 21, 2025
ff03200
fix: add types
lotharking Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ jobs:
yarn install --immutable
yarn build
rm -rf src/bin/
chmod +x build/bin/*
yarn config set npmAuthToken ${NPM_AUTH_TOKEN}
yarn npm publish --access public
env:
Expand Down
2 changes: 1 addition & 1 deletion examples/converter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@
},
"packageManager": "yarn@3.6.1",
"dependencies": {
"jp2-to-image": "^0.0.18"
"jp2-to-image": "^0.0.19"
}
}
10 changes: 5 additions & 5 deletions examples/converter/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ __metadata:
resolution: "converter@workspace:."
dependencies:
"@types/node": ^18.19.79
jp2-to-image: ^0.0.18
jp2-to-image: ^0.0.19
prettier: ^3.2.5
rimraf: ^6.0.1
ts-node: ^10.9.2
Expand Down Expand Up @@ -285,10 +285,10 @@ __metadata:
languageName: node
linkType: hard

"jp2-to-image@npm:^0.0.18":
version: 0.0.18
resolution: "jp2-to-image@npm:0.0.18"
checksum: 31e393b5b22001f468e88c2725c5c787bf4fa3891bc3ba7e5def1acbe02e8c0392018a39ba9d9364235671674e3207e226b6be4e96b7d8144883b531e4e6677f
"jp2-to-image@npm:^0.0.19":
version: 0.0.19
resolution: "jp2-to-image@npm:0.0.19"
checksum: 47a24ef75153bf5387336a40d6f5f63c43cd6602e7eb8b5fea9a7d53baaca2fed9ceb2f074056450155c919e898143029ad94c6a00a9c9ea7bbad0320f136409
languageName: node
linkType: hard

Expand Down
6 changes: 5 additions & 1 deletion lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"access": "public"
},
"devDependencies": {
"@types/fs-extra": "^11.0.4",
"@types/jest": "^29.5.14",
"@types/node": "^18.19.79",
"@typescript-eslint/eslint-plugin": "^6.0.0",
Expand All @@ -64,5 +65,8 @@
"engines": {
"node": ">= 18"
},
"packageManager": "yarn@3.6.1"
"packageManager": "yarn@3.6.1",
"dependencies": {
"fs-extra": "^11.3.0"
}
}
6 changes: 6 additions & 0 deletions lib/src/JPEG2000NodeConverter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { spawn } from 'child_process'
import * as fs from 'fs-extra'
import * as path from 'path'

export class JPEG2000NodeConverter {
Expand All @@ -14,6 +15,11 @@ export class JPEG2000NodeConverter {
else throw new Error(`Unsupported platform: ${platform}`)

this.binPath = path.resolve(__dirname, 'bin', binFileName)

if (platform !== 'win32') {
fs.ensureFileSync(this.binPath)
fs.chmodSync(this.binPath, 0o755)
}
}

/**
Expand Down
Loading
Loading