Add alert handler to ot_earlgrey#110
Merged
jwnrt merged 2 commits intolowRISC:dev/ot-earlgrey-1.0.0-updatesfrom Jan 22, 2025
Merged
Add alert handler to ot_earlgrey#110jwnrt merged 2 commits intolowRISC:dev/ot-earlgrey-1.0.0-updatesfrom
jwnrt merged 2 commits intolowRISC:dev/ot-earlgrey-1.0.0-updatesfrom
Conversation
rivos-eblot
requested changes
Jan 22, 2025
rivos-eblot
left a comment
rivos-eblot
left a comment
There was a problem hiding this comment.
LGTM, except the file header (lowRISC, 2025 ... 😄)
Connect the alerts for each of the OpenTitan Earlgrey devices to the alert handler. This is based on the mappings found in the autogenerated `hw/top_earlgrey/sw/autogen/top_earlgrey.h` file for the Earlgrey top found in the OpenTitan repository. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
Connects GPIO signals for the four different escalation severities of OpenTitan Earlgrey's Alert handler. For now, escalation signal 3 (phase 3) connects to the pwrmgr, where it causes a shutdown as is the default in Darjeeling. In reality, the alert handler should cause a reset in phase 3 and populate the rstmgr's `reset_info` accordingly, but this requires additional work in other blocks, and as such we simply leave this connected to the pwrmgr shutdown for now to match Darjeeling's functionality. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
eg_alert_handler
branch
from
53047de to
480715c
Compare
jwnrt
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two commits that connect the alert handler to the
ot_earlgreyQEMU machine, to allow it to support the same alert handling functionality that is already present inot_darjeeling. See the commit messages for more details.This functionality cannot be appropriately tested by the existing alert handler tests, which require additional functionality either in the alert handler or other blocks. With the additional changes from #111 on top, which adds support for NMIs, I can see that
rv_core_ibex_nmi_irq_testis passing, which makes simple use of the alert handler with a pwrmgr fatal alert.