Fixes to date & timezone parsing, add ignore_errors flag#51
Open
Fixes to date & timezone parsing, add ignore_errors flag#51
Conversation
Owner
|
This approach seems somewhat heavy-handed to me. Is there a particular kind of error that is expected? |
Author
|
Are you talking about ignore_errors, or custom timezones parsing? The custom timezones I agree it's not great, the ideal would be to actually interpret VTIMEZONE properly. I can remove that part of the handling if you'd like. This comes from crashes we've seen trying to parse user ics files, mostly generated by Outlook 365. I can also attach some samples if that's helpful. |
Owner
|
The ignoring of errors part. I would much rather handle it without swallowing exceptions. Is there a particular bit that is expected to fail? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen a number of errors in Outlook-generated ICS files in the wild. This PR adds a few fixes to make the parser more flexible: