Skip to content

Support symbols#42

Merged
lpil merged 2 commits intolpil:mainfrom
silby:symbol
Jan 19, 2026
Merged

Support symbols#42
lpil merged 2 commits intolpil:mainfrom
silby:symbol

Conversation

@silby
Copy link
Contributor

@silby silby commented Jan 2, 2026

the html rendering is identical to what djoths and thus pandoc do: you get a <span class="symbol">contents</span>. There's an argument for making this a knob and just rendering the symbols as plain text if not requested but I'm not here to add knobs.

PR contains an unrelated tweak to the test helpers which you are free to drop.

Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Thanks for figuring out how we should render this as HTML. I think your approach of following pandoc makes a lot of sense 👍

I've left a note inline RE the parsing technique

@silby
Copy link
Contributor Author

silby commented Jan 8, 2026

Repushed, thanks.

@silby silby requested a review from lpil January 8, 2026 19:43
@silby silby force-pushed the symbol branch 2 times, most recently from ec3a3d1 to edb0be8 Compare January 8, 2026 20:02
Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, couple more notes inline.

e.g. vim swap files, which was making it annoying to tweak a test case
because I kept having to close the file for the tests to run.
@silby
Copy link
Contributor Author

silby commented Jan 15, 2026

Repushed. I still am not confident I understand what you are asking for re: iteration.

@silby
Copy link
Contributor Author

silby commented Jan 19, 2026

This should be ok now I think.

Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil merged commit 4d782a1 into lpil:main Jan 19, 2026
1 check passed
@silby silby deleted the symbol branch January 26, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants