Draft
Conversation
…s the now lost clean up of the 1.20.5 commit
… to get removed from the very same liste by prepending it with a minus. This should make the config more intuitive, since the orientation is set in the same list where it gets used. - added some default belt items - added special case for fishing rod and OnAStickItems - made shield offset configurable - deduplicated code - allow belt items to work wit offhand - fixed bug if both offhand and mainhand items get rendered, affecting each other (bow + shield) - update cloth config version - removed Herobrine from the minecraft movie - fixed bug of some items not getting rotated correctly (bow)
FireInstall
force-pushed
the
experimental
branch
from
70662eb to
e49b812
Compare
Owner
|
It is looking pretty good, I like the changes. We just need to make sure we don't introduce new bugs with this 😂. You are doing well, thanks for the work |
Collaborator
Author
|
Well, I really hope we don't. As far as I know, I've tested everything. Anyways. With your approval I will roll out these three PRs as planed with the 1.21.5 update, thanks for your time! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #29
This is pretty experimental and there was no good reason to rework this code, I just saw the opportunity with Tags and ran with it.
Fixed some bugs on the way. Probably introduced a bunch of new ones.
If we gonna merge this, we should wait for the spring drop and merge the offset, (tag,) and this branch at once, so the user just have to regenerate their config once (no idea how to elegantly do the config with the offset tho).
Since it is just an experiment, I'm also happy to see this PR getting closed. We just should fix the bugs I found while testing my changes anyway.