DM-49384: Restore some sort of caching for downloading HD 111980 from simbad#59
Open
DM-49384: Restore some sort of caching for downloading HD 111980 from simbad#59
Conversation
Pull Request Test Coverage Report for Build 13740764646Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With rubinenv 9 we had astroquery 0.4.6 which supported caching, so we could store the cached version of the HD 111980 simbad table and it would use that. As of astroquery 0.4.8 they completely refactored the query system / units / fields / etc and also remove all caching ability.
I tried using vcr, but that crashed on record (some incompatibility between pyvo and new vcrpy maybe? I don’t know).
So my solution is to put special-case code in spectractor when running on jenkins. It’s not pretty, but it does work locally (at least).