Skip to content

DM-53313-v30: Check for very small change in chi2 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsaunders merged 1 commit into from
Feb 14, 2026
Merged

DM-53313-v30: Check for very small change in chi2 #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion python/lsst/meas/algorithms/maskStreaks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,13 @@ def line_search(c, dx):
break
dx = scipy.linalg.cho_solve(cholesky, b)

factor, fmin, _, _ = scipy.optimize.brent(line_search, args=(dx,), full_output=True, tol=0.05)
if abs(line_search(1, dx) - chi2) < 1e-12:
# Step size is too small for the brent line search to work well.
# Just use the step fit from the Cholesky solve.
factor = 1
else:
factor, _, _, _ = scipy.optimize.brent(line_search, args=(dx,), full_output=True, tol=0.05)

x -= factor * dx
if (abs(x[0]) > 1.5 * self._rhoMax) or (iter > maxIter):
fitFailure = True
Expand Down Expand Up @@ -921,6 +927,7 @@ def _fitProfile(self, lines, maskedImage, detectionMask=None):
# Drop this line if the model profile is below the footprint
# threshold
if not finalLineMask.any():
self.log.debug("Streak model profile is below the footprintThreshold.")
continue
fit.modelMaximum = finalModelMax
lineFits.append(fit)
Expand Down