Skip to content

DM-54159: Update use of butler-stored detector pointing and regions in single frame processing #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurenam merged 1 commit into from
Feb 18, 2026
+18 −4
Merged

DM-54159: Update use of butler-stored detector pointing and regions in single frame processing #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions python/lsst/meas/algorithms/loadReferenceObjects.py
View file
Open in desktop
Copy link
Member

@TallJimbo TallJimbo Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is missing a word near "sky positions the reference catalog".

Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ def _filterFunction(refCat, region):
return filteredRefCat
return self.loadRegion(outerSkyRegion, filterName, filtFunc=_filterFunction, epoch=epoch)

def loadRegion(self, region, filterName, filtFunc=None, epoch=None):
def loadRegion(self, region, filterName, filtFunc=None, epoch=None, wcsForCentroids=None):
"""Load reference objects within a specified region.

This function loads the DataIds used to construct an instance of this
Expand Down Expand Up @@ -651,6 +651,9 @@ class which intersect or are contained within the specified region. The
epoch : `astropy.time.Time` or `None`, optional
Epoch to which to correct proper motion and parallax, or `None` to
not apply such corrections.
wcsForCentroids : `lsst.afw.geom.SkyWcs`, optional
If provided, this WCS will be used to convert the reference catalog
sky coordinates to pixel positions.

Returns
-------
Expand Down Expand Up @@ -747,9 +750,20 @@ class which intersect or are contained within the specified region. The

self.applyProperMotions(refCat, epoch)

expandedCat = self._remapReferenceCatalogSchema(refCat,
anyFilterMapsToThis=self.config.anyFilterMapsToThis,
filterMap=self.config.filterMap)
if wcsForCentroids is not None:
expandedCat = self._remapReferenceCatalogSchema(
refCat,
anyFilterMapsToThis=self.config.anyFilterMapsToThis,
filterMap=self.config.filterMap,
centroids=True,
)
afwTable.updateRefCentroids(wcsForCentroids, expandedCat)
else:
expandedCat = self._remapReferenceCatalogSchema(
refCat,
anyFilterMapsToThis=self.config.anyFilterMapsToThis,
filterMap=self.config.filterMap,
)

# Ensure that the returned reference catalog is continuous in memory
if not expandedCat.isContiguous():
Expand Down