DM-54397: Add task for computing a rough shapelet expansion of isolated stars.#467
Open
DM-54397: Add task for computing a rough shapelet expansion of isolated stars.#467
Conversation
TallJimbo
force-pushed
the
tickets/DM-54397
branch
from
54502cd to
aa9b3dc
Compare
laurenam
reviewed
Mar 17, 2026
Contributor
laurenam
left a comment
laurenam
left a comment
There was a problem hiding this comment.
Just some flyby comments while perusing…
| * `lsst.afw.geom.SpanSet`. | ||
| * | ||
| * This class provides low-level pixel-processing code for | ||
| * `ComputeRoughtPsfShapeletsTask`. |
| /// The pixels actually used to compute the moments. | ||
| std::shared_ptr<afw::geom::SpanSet> spans; | ||
|
|
||
| /// Flag if there were too many bad pixels to compute the moments. |
Contributor
There was a problem hiding this comment.
“Flag if” —> “Flag set if” to match those below?
| /// Flag set if there was a bad pixel too close to the center. | ||
| bool bad_pixel_in_center = false; | ||
|
|
||
| /// Flag set if the second moments do not resolve to an ellipse. |
Contributor
There was a problem hiding this comment.
Tense is changed from above, i.e. “do not” vs. “did not” & “was”.
| /// Flag set if the second moments do not resolve to an ellipse. | ||
| bool singular_second_moments = false; | ||
|
|
||
| /// Test whether any failure falg is set. |
| * | ||
| * @param[in] spans Pixel region to use. | ||
| * @param[in] masked_image Image to measure. | ||
| * @param[in] bad_bitmask Mask of bad pixels to remove from `spans` to |
| * before giving up. | ||
| * @param[in] bad_pixel_exlusion_radius Radius around the estimated | ||
| * center where bad pixels will | ||
| * cause the algorithm to give up. |
Contributor
There was a problem hiding this comment.
I don’t quite follow this description…
Member
Author
There was a problem hiding this comment.
It's a radius that tries to act analogously to a cut on base_PixelFlags_[bad_bitmask]Center, but about the center the algorithm is computing itself. I've reworded slightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.