Skip to content

tickets/SP-2741: use observation_reason as default field to map to color in some plots #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehneilsen merged 2 commits into from
Mar 19, 2026
Merged

tickets/SP-2741: use observation_reason as default field to map to color in some plots #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c7faed
use observation_reason as default field to map to color in plot_polar…
ehneilsen Feb 10, 2026
22e0726
black 26.1.0
ehneilsen Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions schedview/plot/nightly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def plot_alt_vs_time(
Bokeh figure object to plot on. If None, a new figure will be created.
note_column : `str` or None
The column to use as the note to map to color.
Defaults to None, which defaults `scheduler_note` if it is present
Defaults to None, which defaults `observation_reason` if it is present
in the visit datasource, otherwise `note`.

Returns
Expand All @@ -200,10 +200,10 @@ def plot_alt_vs_time(

if note_column is None:
if isinstance(visits, bokeh.models.ColumnDataSource):
scheduler_note_present = "scheduler_note" in visits.data
observation_reason_present = "observation_reason" in visits.data
else:
scheduler_note_present = "scheduler_note" in visits
note_column = "scheduler_note" if scheduler_note_present else "note"
observation_reason_present = "observation_reason" in visits
note_column = "observation_reason" if observation_reason_present else "note"

for time_column in "start_timestamp", "observationStartDatetime64":
if isinstance(visits, bokeh.models.ColumnDataSource):
Expand Down Expand Up @@ -412,10 +412,10 @@ def plot_polar_alt_az(visits, band_shapes=BAND_SHAPES, figure=None, legend=True,
"""
if note_column is None:
if isinstance(visits, bokeh.models.ColumnDataSource):
scheduler_note_present = "scheduler_note" in visits.data
observation_reason_present = "observation_reason" in visits.data
else:
scheduler_note_present = "scheduler_note" in visits
note_column = "scheduler_note" if scheduler_note_present else "note"
observation_reason_present = "observation_reason" in visits
note_column = "observation_reason" if observation_reason_present else "note"

if figure is None:
fig = bokeh.plotting.figure(
Expand Down
Loading