tickets/SP-3008: Bug fixes and improved tools for comparison of completed visits and pre-night sims#196
Open
tickets/SP-3008: Bug fixes and improved tools for comparison of completed visits and pre-night sims#196
Conversation
ehneilsen
force-pushed
the
tickets/SP-3008
branch
2 times, most recently
from
0d5e4b2 to
7c25abc
Compare
ehneilsen
force-pushed
the
tickets/SP-3008
branch
from
7c25abc to
85c963f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started off as a bug fix for comparenight being too picky about how it was matching simulated visits to visits in the prenight simulation, failing to match visits when the pointing was not in the same healpixel. This change replaces the simple healpix-based strategy with coordinate matching taking advantage of astropy's catalog matching tools.
While debugging, I also added several improved tools for showing tables and figures that compare simulated with actual visits. I think these greatly improve on what was in comparenight before. There will be a corresponding PR on schedview_notebooks (which will depend on this PR in schedview) shortly.