fix: add missing #include <cstdint> for GCC 15 / C++23 compatibility#44
Open
jeffreyschultz wants to merge 2 commits intoluetge:masterfrom
Open
fix: add missing #include <cstdint> for GCC 15 / C++23 compatibility#44jeffreyschultz wants to merge 2 commits intoluetge:masterfrom
jeffreyschultz wants to merge 2 commits intoluetge:masterfrom
Conversation
- Add #include <cstdint> to definitions.h for uint32_t, int32_t, int64_t, int16_t, and uintptr_t which are no longer transitively provided by other headers in GCC 15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GCC 15 and recent Clang versions with C++23 mode no longer transitively provide
<cstdint>through other standard headers. This causes build failures becausedefinitions.husesuint32_t,int32_t,int64_t,int16_t, anduintptr_twithout including the header that defines them.Changes
#include <cstdint>toinclude/definitions.hMotivation
This is required to build flagser (and downstream projects like pyflagser) with:
Without this fix, the build fails with:
Testing