feat: add Google Ads, Tag Manager, Analytics, and Slides as supported OAuth services#427
Open
danahmadi wants to merge 5 commits intolukilabs:mainfrom
Open
feat: add Google Ads, Tag Manager, Analytics, and Slides as supported OAuth services#427danahmadi wants to merge 5 commits intolukilabs:mainfrom
danahmadi wants to merge 5 commits intolukilabs:mainfrom
Conversation
Add 'search-console' to the GoogleService type, scope mapping, and config validator so Search Console sources can authenticate via the built-in Google OAuth flow with webmasters.readonly scope. Co-Authored-By: Craft Agent <agents-noreply@craft.do>
Author
|
This is my first PR to a public project, ever -- don't hold back |
Collaborator
|
Amazing, thanks. Will add. YouTube as well :) |
Per reviewer feedback, adds 'youtube' with youtube.readonly scope alongside the search-console addition. Co-Authored-By: Craft Agent <agents-noreply@craft.do>
Match the pattern of other Google services which all use full access. - search-console: webmasters → webmasters (was webmasters.readonly) - youtube: youtube → youtube (was youtube.readonly) Co-Authored-By: Craft Agent <agents-noreply@craft.do>
…vices Scopes verified against official Google API docs: - ads: adwords (full Google Ads access) - tag-manager: manage.accounts + edit.containers + edit.containerversions + publish + readonly (comprehensive GTM management) - analytics: analytics + analytics.readonly (GA4 view and manage) - slides: presentations (full Slides access) Co-Authored-By: Craft Agent <agents-noreply@craft.do>
Author
|
Thanks! Added YouTube along with Google Ads, Tag Manager, Analytics (GA4), and Slides in the latest commit.... figured we'd cover the most commonly used Google APIs in one go. All scopes verified against official Google docs. |
Collaborator
|
Good point. Adding them together with youtube. |
Adopt upstream naming convention (searchconsole instead of search-console) and readonly scope from main, while keeping ads, tag-manager, analytics, and slides services from this branch. Co-Authored-By: Craft Agent <agents-noreply@craft.do>
danahmadi
changed the title
danahmadi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search-consoleto theGoogleServicetype union,GOOGLE_SERVICE_SCOPESmapping, and Zod config validatorwebmasters.readonlyscopeCurrently, setting up a Google Search Console source fails because
search-consoleisn't recognized as a validgoogleServicevalue. This is a minimal change (3 files, ~4 lines) that follows the exact same pattern as the existing 5 Google services.Files changed
packages/shared/src/sources/types.ts'search-console'toGoogleServicetypepackages/shared/src/auth/google-oauth.tswebmasters.readonlypackages/shared/src/config/validators.ts'search-console'to Zod enumTest plan
"googleService": "search-console"webmasters.readonlyscope is requested🤖 Generated with Claude Code