Skip to content

security: AI Fix for Potential SQL injection via string-based query concatenation #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

security: AI Fix for Potential SQL injection via string-based query concatenation #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions adapters/sqlstore/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"database/sql"
"encoding/json"
"regexp"

"github.com/luno/jettison/errors"
"github.com/luno/jettison/j"
Expand Down Expand Up @@ -87,6 +88,9 @@ func (s *SQLStore) insertOutboxEvent(
workflowName string,
data []byte,
) (int64, error) {
if !regexp.MustCompile(`^[a-zA-Z0-9_]+$`).MatchString(s.outboxTableName) {
Copy link
Collaborator

@andrewwormald andrewwormald Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would imply the attacker has access to the source code. Will close as this doesnt prevent the attacker then from removing this check.

return 0, errors.New("invalid table name")
}
resp, err := tx.ExecContext(ctx, "insert into "+s.outboxTableName+" set "+
" id=?, workflow_name=?, data=?, created_at=now() ",
id,
Expand Down