Draft
Conversation
Added workflow for video crop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added VP9 SVC support via SDP munging following Mediasoup and Iñaki Baz Castillo approach, so credits to him. The existing VP9 packet parser included in Licode supports this type of packets so only changes in the client are necessary. It only works with Chrome starting from chrome 74 and is not officially supported. To enable it publish the stream with the following flag:
room.publish(localStream, {svc:true});
In my tests, without using any chrome flag, the browser sends 2 spatial layers (corresponding with licode's layer 0 and 1) and three spatial layers (corresponding with licode's layer 0, 1 and 2)
Also added controls in the basicExample to switch between layers when SVC or simulcast are active.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
TODO: Write the documentation for the final PR.
[X] It includes documentation for these changes in
/doc.