Removes CSP headers in dev environment#508
Open
joehakimrahme wants to merge 1 commit intolyrgard:masterfrom
Open
Removes CSP headers in dev environment#508joehakimrahme wants to merge 1 commit intolyrgard:masterfrom
joehakimrahme wants to merge 1 commit intolyrgard:masterfrom
Conversation
The CSP headers included in the requests are causing failures with fontawesome. This in turn is causing some functionality (like pinning or banning specific items in the builders) to disappear. This patch removes the CSP headers from requests if the app is launched in dev mode. It does make the app vunlerable to XSS attacks but, hey, it's dev mode. Don't run this in production anyway. Fixes lyrgard#507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSP headers included in the requests are causing failures with
fontawesome. This in turn is causing some functionality (like pinning or
banning specific items in the builders) to disappear.
This patch removes the CSP headers from requests if the app is launched
in dev mode. It does make the app vunlerable to XSS attacks but, hey,
it's dev mode. Don't run this in production anyway.
Fixes #507