fix: identifyRequest intake when persistent data exists#1014
Open
deammer wants to merge 2 commits intomParticle:developmentfrom
Open
fix: identifyRequest intake when persistent data exists#1014deammer wants to merge 2 commits intomParticle:developmentfrom
deammer wants to merge 2 commits intomParticle:developmentfrom
Conversation
Author
|
@alexs-mparticle tagging you here as requested! |
alexs-mparticle
requested changes
Apr 7, 2025
Collaborator
alexs-mparticle
left a comment
alexs-mparticle
left a comment
There was a problem hiding this comment.
This PR is a great start. Thanks for opening it. My main request is for you to write some tests around the new feature to make sure any dependent functionality isn't affected.
|
Author
|
Hey @alexs-mparticle thank you for the review 🙏 I've made the changes you requested except for writing tests, which looks pretty involved based on a brief look I took. Is there any chance you or your team could take care of that? |
rmi22186
force-pushed
the
development
branch
5 times, most recently
from
905641c to
b16bdd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue with identifying users in certain contexts, namely across subdomains. See this comment for more information.
Resolves #1010.
Testing Plan
The testing scenario:
a. mParticle initializes on the subdomain
b. mParticle starts a session and stores it in local storage
a. mParticle initializes on the subdomain
b. mParticle starts a session and stores it in local storage
a.
mParticle.login()is calledb. a cookie containing the
customeridis storedc. user is thus identified on login.website.com
a. mParticle initializes on the subdomain
b. mParticle does not start a new session because there's already one in local storage
Before this fix: users would not be identified.
With this fix: users are consistently identified.