Improve spec compliance, Android interim results, iOS fix for simultaneous speech synthesis.#114
Open
wifisher wants to merge 33 commits intomacdonst:masterfrom
Open
Improve spec compliance, Android interim results, iOS fix for simultaneous speech synthesis.#114wifisher wants to merge 33 commits intomacdonst:masterfrom
wifisher wants to merge 33 commits intomacdonst:masterfrom
Conversation
The event handler now uses the SpeechRecognitionError object.
… speechRecognitionAllowAudioOutput
Collaborator
|
Wow, awesome work, but please, keep Pull Requests simple, it's preferable that you send 5-6 separate PRs, (one per feature/bug), so it's easier to review and merge. |
Author
|
I fixed what I needed locally and then decided that I should give it back to the community and pushed up my local changes. I don't spend much time on Github and it would only let me submit a PR from the head of my master branch. I don't have time to break it out into individual branches so I figured that one bigger PR is better than not doing it at all. Assuming that you have visibility into the individual commits, they are smaller and fairly self contained. It is likely to be easier to review each commit separately than to review the combined changes for the PR. |
…alized due to changes to sampleRate. Clean up iOS logging. Added iOS plugin status return for init().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Motivation and Context
Improves ability to use the same application code for Android, and iOS apps as well as for Chrome.
How Has This Been Tested?
Works in my test app for Android and iOS. The same app code also works in Chrome.
Types of changes
Checklist: