Open
Conversation
… using __future__ and six
…enerating single codepoints from surrogate pairs which cannot be encoded in utf-8. Python 2 was more lax about this
…scii input is supplied. This is something which is ambiguous in python 2, however in python 3 the split between text and bytes is much more explicit
|
Hi , is Quepy working on python 3.5? I have errors and I have included the modification of this pull request |
Soumendra kumar sahoo (soumendrak)
suggested changes
Jul 22, 2018
Soumendra kumar sahoo (soumendrak)
left a comment
Soumendra kumar sahoo (soumendrak)
left a comment
There was a problem hiding this comment.
Empty file test.sh added in PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a few changes to quepy app and tests so that python 3 is working in the test suite. I skipped the tests which check that a Value is raised when ascii input is given, since this should be less of an issue with python3.