Added ability for describe bracketed modifiers#344
Open
evgenibir wants to merge 23 commits intomachty:masterfrom
Open
Added ability for describe bracketed modifiers#344evgenibir wants to merge 23 commits intomachty:masterfrom
evgenibir wants to merge 23 commits intomachty:masterfrom
Conversation
… and glimmer components
…ons converted to `<comp.subcomp @value=foo>` (angel component definition)
…nting close bracket in multi-line declarations because it leads to syntax glitches
… components. also added ability to define block params in the start of blocked component instead of end but in the end definition also supported
…ents and mustache definitions
…alue=foo`. Also glimmer component will be non-blocked if it's not contain nested nodes. resolved machty#338
|
@evgenibir This is really great. Shame it hasn't been merged into this main project. Quick question, having issues using your forked project because ember-cli-emblem installs this older version in its own dependencies during npm install. How did you go about resolving this on your own project in the interim? thanks! |
|
I did notice one compilation difference, but its minor. In the following example on 0.12.1 this would compile plain text, but in 0.13.4 it breaks and says that you cannot have the '[ ]' square brackets. This occurred only once in our code and was easily changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all! I noticed that #336 and 335 and fixed it. Please let me know your opinion.
like this live examples
also fixed

so that works now
Added angel bracket separator for
%comp>subcomp @value=foodefinitions converted to<comp.subcomp @value=foo>(angel component definition) for issue 337 and 332will be parsed to
Support Template Literal 314
Added support for #326 but removed workaround code with no dedenting close bracket in multi-line declarations because it leads to syntax glitches
now any non
dedentbracket is invalid like thisclose bracket should be on the same line as open
Added support for #339
Added test case for #333 but actually that works
Added ability for defining inline shorthands in html-tags and glimmer components. also added ability to define block params in the start of blocked component instead of end but in the end definition also supported
Added destructuring to block params definition: inside glimmer components and mustache definitions
Added support for non-block components definitions with
%my-comp/ @value=foo.Also glimmer component will be non-blocked if it's not contain nested nodes.
resolved #338
Added syntax error suggester
So that It's not back compatible patch