Skip to content

fix(ch11 rClient.go): handle nil HTTP response and print server body #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AsherLaxman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ch11 rClient.go): handle nil HTTP response and print server body #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions ch11/rClient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ func deleteEndpoint(server string, user User) int {
if err != nil {
fmt.Println("Error:", err)
}
defer resp.Body.Close()

if resp == nil {
return http.StatusBadRequest
}
defer resp.Body.Close()

data, err := io.ReadAll(resp.Body)
fmt.Print("/delete returned: ", string(data))
Expand Down Expand Up @@ -80,12 +80,13 @@ func getEndpoint(server string, user User) int {
resp, err := c.Do(req)
if err != nil {
fmt.Println("Error:", err)
return http.StatusBadGateway
}
defer resp.Body.Close()

if resp == nil {
return resp.StatusCode
return http.StatusBadGateway
}
defer resp.Body.Close()

data, err := io.ReadAll(resp.Body)
fmt.Print("/get returned: ", string(data))
Expand Down Expand Up @@ -116,11 +117,15 @@ func addEndpoint(server string, user User) int {
}

resp, err := c.Do(req)
if resp == nil || (resp.StatusCode == http.StatusNotFound) {
return resp.StatusCode
if err != nil {
fmt.Println("do:", err)
return http.StatusBadGateway
}
defer resp.Body.Close()

if resp.StatusCode == http.StatusNotFound {
return http.StatusNotFound
}
return resp.StatusCode
}

Expand All @@ -136,8 +141,9 @@ func timeEndpoint(server string) (int, string) {
}

resp, err := c.Do(req)
if resp == nil || (resp.StatusCode == http.StatusNotFound) {
return resp.StatusCode, ""
if err != nil {
fmt.Println("do:", err)
return http.StatusBadGateway, ""
}
defer resp.Body.Close()

Expand All @@ -158,7 +164,7 @@ func slashEndpoint(server, URL string) (int, string) {

resp, err := c.Do(req)
if resp == nil {
return resp.StatusCode, ""
return http.StatusBadGateway, ""
}
defer resp.Body.Close()

Expand Down