Compile & Min LESS when output files don't exist #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a project where .min.css and .css products of LESS compilation don't exist (e.g. build output isn't source controlled), the min.css and .css files are not currently rebuilt - this change attempts to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was having trouble with my team - we don't commit compiled or minified LESS to source control. When working individually on projects, we'd have to open all LESS files and use the save listener to re-create the .min.css and .css files in order for the LESS compilation to kick in and start checking these on build.
I think Issue #14 describes similar problems (although I didn't experience the crash).
There did seem to be some explicit checking for not compiling in these conditions (CanCompile function, Lines 41-49) so these changes may be unacceptable if there's a scenario I haven't considered here.