Emit target_os = ... cfgs on framework dependencies
#618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
madsmtm
force-pushed
the
dependency-target-cfgs
branch
3 times, most recently
from
4ad1bff to
10a18b5
Compare
It wasn't used, and doesn't have an equivalent in Rust (yet?).
`cfg`-gate target-dependent dependencies in crate frameworks.
madsmtm
force-pushed
the
dependency-target-cfgs
branch
from
728c9f8 to
3bdc9bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework crates like
objc2-app-kitcannot be used on e.g. tvOS, and neither can the functionality that depend on types from that crate. This is also problematic for GNUStep.This is similar to (and lays some of the groundwork for) #433, but distinct in that the cfgs are only emitted when a dependency is required, not for all items.