Stefan Popescu - Curs 2 - Code Challenge 1 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magdamiu
reviewed
Jul 6, 2021
|
|
||
| <TextView | ||
| android:layout_weight="1" | ||
| android:layout_width="fill_parent" |
Owner
There was a problem hiding this comment.
Please just be aware that fill parent is deprecated in API level 8 https://developer.android.com/reference/android/view/ViewGroup.LayoutParams#FILL_PARENT
| <RatingBar | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:progressTint="#ED5087" |
Owner
There was a problem hiding this comment.
Please consider adding the colors in colors,xml to be able reusing them
| <RadioGroup | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_margin="5dp"> |
Owner
There was a problem hiding this comment.
Please consider defining some pre-defined margins/paddings. Use numbers that are multiple of 8 (example: 8, 16, 32, 64, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.