Conversation
There was a problem hiding this comment.
You are referencing a #83 here probably from other project since it is completely unrelated to what we have here. For referencing other projects you should put the whole link (magmax/python-readchar#83) to avoid confusion of developers reading this code.
| elif pressed == key.RIGHT: | ||
| if self.current not in self.selection: | ||
| self.selection.append(self.current) | ||
| elif pressed == key.CTRL_A: |
There was a problem hiding this comment.
You added new branches to the code without adding tests for them. So this change request is reducing our test coverage. Please update the tests.
There was a problem hiding this comment.
Instead of adding a code while a PR is not merged, I would focus in having the dependency updated. This is creating some double work for you, me and other people working on python-inquirer.
There was a problem hiding this comment.
Last update in readchar 4 feb 2022. I dont now, how many time need for merge it.
There was a problem hiding this comment.
@magmax do you think we can have a new version with magmax/python-readchar#83 in forseable future?
There was a problem hiding this comment.
Now magmax/python-readchar#83 is part of magmax/python-readchar#79 , but in case of a successful answer, I will reopen that MP
There was a problem hiding this comment.
this is already merged and in pre-release state
| self.selection = list(range(len(self.question.choices))) | ||
| elif pressed == key.CTRL_Q: | ||
| self.selection = [] | ||
| elif pressed == key.ENTER: |
There was a problem hiding this comment.
Also I see there are no mentions of the changes on documentation and change-logs.
There was a problem hiding this comment.
Where do i can found change-logs files?
fleytman
force-pushed
the
patch-1
branch
2 times, most recently
from
552f71b to
273131e
Compare
|
FYI: the changes requested in magmax/python-readchar#83 are now merged and will come avalabel in |
change comment in tests
Cube707
added
blocked
|
|
|
part of this is handeld in #275 and shift support is not portable anyway. So I am closing this |
3 participants
ctrl+a select all
ctrl+q deselect all
tab move down
tab+shift move uo
after merge #83 remove 68-69 strings