-
Notifications
You must be signed in to change notification settings - Fork 0
authorization #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
authorization #12
Conversation
ZabihullahNooriWardak
commented
Dec 17, 2023
- Installed cancancan gem
- Generated migration for role column in users
- Built schema.rb with role column in users table
- Handled invalid paths or records along with invalid access
- Authorized loaded resources in all controllers
- Implemented destroy action with authorization in controllers
- Restructured post & post views to insert delete link
- Styled action links in posts & comments to add delete link
zieeco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: APPROVED 🟢 💯
Hi, @Team,
Good job so far 👍 Your project is complete! There is nothing else to say other than... it's time to merge it ![]()
Congratulations! 🎉
Highlights ⚡
✅ Descriptive PR 👍
✅ Nice authorization 🔥
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
