Skip to content

Conversation

@ZabihullahNooriWardak
Copy link
Collaborator

  1. Installed cancancan gem
  2. Generated migration for role column in users
  3. Built schema.rb with role column in users table
  4. Handled invalid paths or records along with invalid access
  5. Authorized loaded resources in all controllers
  6. Implemented destroy action with authorization in controllers
  7. Restructured post & post views to insert delete link
  8. Styled action links in posts & comments to add delete link

Copy link

@zieeco zieeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status: APPROVED 🟢 💯

Hi, @Team,

68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f78543078657a514755357843444a754350652f67697068792e676966

Good job so far 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights ⚡

✅ Descriptive PR 👍
✅ Nice authorization 🔥

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants