Skip to content

Make BANNER constant private #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcouball merged 2 commits into from
Apr 15, 2025
Merged

Make BANNER constant private #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999c1c0
refactor: make BANNER constant private
jcouball Apr 15, 2025
50ec4f4
refactor: only fail the build for low coverage on non-windows MRI
jcouball Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/continuous_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,28 @@ jobs:
runs-on: ${{ matrix.operating-system }}
continue-on-error: true

env:
FAIL_ON_LOW_COVERAGE: ${{ matrix.fail_on_low_coverage }}

strategy:
fail-fast: false
matrix:
ruby: ["3.1", "3.2", "3.3", "jruby-9.4", "truffleruby-24"]
ruby: ["3.1", "3.4"]
operating-system: [ubuntu-latest]
fail_on_low_coverage: ["true"]
include:
- ruby: "jruby-9.4"
operating-system: ubuntu-latest
fail_on_low_coverage: "false"
- ruby: "truffleruby-24"
operating-system: ubuntu-latest
fail_on_low_coverage: "false"
- ruby: "3.1"
operating-system: windows-latest
fail_on_low_coverage: "false"
- ruby: "jruby-9.4"
operating-system: windows-latest
fail_on_low_coverage: "false"

steps:
- name: Checkout
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/experimental_ruby_builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,28 @@ jobs:
runs-on: ${{ matrix.operating-system }}
continue-on-error: true

env:
FAIL_ON_LOW_COVERAGE: ${{ matrix.fail_on_low_coverage }}

strategy:
fail-fast: false
matrix:
include:
- ruby: head
operating-system: ubuntu-latest
fail_on_low_coverage: "true"
- ruby: head
operating-system: windows-latest
fail_on_low_coverage: "false"
- ruby: truffleruby-head
operating-system: ubuntu-latest
fail_on_low_coverage: "false"
- ruby: jruby-head
operating-system: ubuntu-latest
fail_on_low_coverage: "false"
- ruby: jruby-head
operating-system: windows-latest
fail_on_low_coverage: "false"

steps:
- name: Checkout
Expand Down
3 changes: 2 additions & 1 deletion exe/revert-github-release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class Parser
COMMAND
end

private_constant BANNER = <<~BANNER.freeze
BANNER = <<~BANNER.freeze
Usage:
#{File.basename($PROGRAM_NAME)} [--help | --version]

Expand All @@ -96,6 +96,7 @@ class Parser

Options:
BANNER
private_constant :BANNER

# Define the options for OptionParser
# @return [void]
Expand Down
Loading