Add initial_branch: option to RubyGit::Worktree.init
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouball
force-pushed
the
init_initial_branch
branch
6 times, most recently
from
e3aaaf1 to
0a8215b
Compare
jcouball
force-pushed
the
init_initial_branch
branch
from
0a8215b to
2148b4f
Compare
Different Ruby engines / platforms (MRI, MRI on Windows, JRuby, TruffleRuby might raise different errors for a similar reasons due to differences in how they implement Process.spawn. This change raises a consistent error when Process.spawn raises an error. Process.spawn does this when it can't even run the given command. If there is a problem once the command is running (uncaught signal, timeout, non-zero exitstatus), the the returned result will contain that information.
jcouball
force-pushed
the
init_initial_branch
branch
from
2148b4f to
1b3c348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to specify the initial branch in the newly created repository.
This also includes a refactoring to move option validation methods (like validate_boolean_option) to the RubyGit::OptionValidators module. This module is designed to be included and/or extended into classes needed to validate options.