Open
Conversation
change var to const or let use template literals instead of concat strings
Contributor
|
Thanks for the PR, @mbaklor! I wonder if the "title instead of cart number" thing should be configurable? Due to the small font, users might prefer to only have the number on the SD, and read the title from the computer screen. |
Author
|
This is actually a good idea, I'll look into implementing it. Would you do it as individual settings for each button or as a global setting for the connection? |
Contributor
|
An individual setting would be the most flexible solution, I guess. |
Author
|
added the checkbox, I can't seem to get it checked by default, so maybe I need to change the wording to "hide cart title" but it feels counterintuitive so for now I leave it at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed
cartPlayerStates[cartIndex]to an object containing both the state and the title, and read the title into the SVG directly from there. This was done by using the parameter names directly from the read packet making expansion to add selected cart or artist support very easy.Changed the element in the SVG from a
textelement to atextAreato support wrapping for long titles.Changed the colors in the buttons to match hex codes from within the mairlist color list
While going over the project I replaced some of the keywords etc to be a little more modern js, including
constandletinstead ofvar, and using template literals instead of concatenating strings, to make it all more readable and better scoped.