Add Line Spacing (LineHeight) support to font designer and rendering pipeline#268
Draft
Add Line Spacing (LineHeight) support to font designer and rendering pipeline#268
Conversation
…peline Co-authored-by: majorsilence <656288+majorsilence@users.noreply.github.com>
…leTextCtl Co-authored-by: majorsilence <656288+majorsilence@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to change line spacing in font settings
Add Line Spacing (LineHeight) support to font designer and rendering pipeline
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LineHeightproperty existed in the RDL data model (Style.cs,StyleInfo.cs) but was never surfaced in the designer UI or applied during rendering.Changes
Designer UI (
RdlDesign)FontCtl.csandStyleTextCtl.cs: Added aLine Heightrow with a combo box (preset values 8pt–72pt, plus free text), and anfxexpression button for dynamic expressions. Controls are added programmatically afterInitializeComponent()to avoid.resxmodifications.LineHeightXML node on load/save, validates input viaDesignerUtility.ValidateSize, and resets dirty flag inApply().FontCtl_Show_InvalidLineHeightstring resource for the validation error.Rendering
PageDrawing.cs(screen/print):si.LineHeight > 0, delegates to newDrawStringWithLineHeight()which word-wraps text into lines viaGetWrappedLines()and draws each line with the configured spacing. Vertical alignment (top/middle/bottom) is computed from total line height.RenderPdf_iTextSharp.cs(PDF):lineSpacing = si.LineHeight > 0 ? si.LineHeight : si.FontSize— used for both linestartYoffset and all vertical-alignment calculations.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.