Chitter challenge #138
Chitter challenge #138
Conversation
…ep(peep)' methods
…ddNewPeep' methods
There was a problem hiding this comment.
Overall a strong expression of the brief, demonstrating a good understanding of async JS and solid test coverage. I'd probably have avoided using a Ruby backend for a JS front-end challenge but as I understand that the app works, this is a minor concern. It does seem that there is a test missing for reverse ordering of the peeps in the view, but again this is minor as it's tested in the client.test.js.
You might try to jazz up the front end with a little CSS, as you have a site that can render all the relevant information from the API; I'm not a huge aesthetic hawk though so this is splitting hairs!
| const response = await fetch('https://chitter-backend-api-v2.herokuapp.com/peeps'); | ||
| const data = await response.json(); | ||
|
|
||
| return data.map(peep => ({ |
There was a problem hiding this comment.
Well done on formatting the API response object in client before it goes into the model array, I struggled with this in my own version. The complexity of your formatted object is quite impressive.
| document.body.innerHTML = fs.readFileSync('./index.html'); | ||
| PeepsClient.mockClear(); | ||
|
|
||
| const fakeClient = {loadPeeps: () => Promise.resolve(['mock peep'])}; |
2 participants
No description provided.