Skip to content

Selection handling fix when adding new item to ComboBox. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
makimat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Selection handling fix when adding new item to ComboBox. #2

makimat wants to merge 1 commit into from

Conversation

@makimat
Copy link
Owner

@makimat makimat commented Jan 23, 2018

vaadin#10284

  • if new item is added, it should be selected
  • if new item isn't added, previous selection should be restored
  • it should be possible to prevent default selection of new items

@Ansku
Selection handling fix when adding new item to ComboBox.
7ce4f33 
vaadin#10284

- if new item is added, it should be selected
- if new item isn't added, previous selection should be restored
- it should be possible to prevent default selection of new items
@makimat
Copy link
Owner Author

makimat commented Jan 24, 2018 •
edited
Loading

Softagram Impact Report for pull/2

Worst file risk:100 Total risk points:249

Change structure - click for full size Impact graph - click for full size
(click for full size graphs)

🔍 Details

File risk levels

  • File risk:100 /Vaadin/framework/client/src/main/java/com/vaadin/client/ui/VComboBox.java
  • File risk:67 /Vaadin/framework/server/src/main/java/com/vaadin/ui/ComboBox.java
  • File risk:62 /Vaadin/framework/client/src/main/java/com/vaadin/client/ui/combobox/ComboBoxConnector.java
  • File risk:11 /Vaadin/framework/shared/src/main/java/com/vaadin/shared/ui/combobox/ComboBoxClientRpc.java
  • File risk:8 /Vaadin/framework/uitest/src/test/java/com/vaadin/tests/components/combobox/ComboBoxSelectingNewItemValueChangeTest.java
  • File risk:1 /Vaadin/framework/uitest/src/main/java/com/vaadin/tests/components/combobox/ComboBoxSelectingNewItemValueChange.java

Softagram impact report is in Beta. Give us feedback at support@softagram.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@makimat @Ansku