-
Notifications
You must be signed in to change notification settings - Fork 64
adding allOf validation and test cases #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
First of all, thank you for the proposal. Instead of test cases being a,b,c,x,y,z blah blah, please use use cases that explain why you need this feature. See also #191 |
| OBJECT_EQUAL_TO("object.equalTo", "\"{0}\" must be equal to {1}"), // | ||
| OBJECT_ONE_OF("object.oneOf", "\"{0}\" must be one of the following values: {1}"), // | ||
| OBJECT_NOT_ONE_OF("object.notOneOf", "\"{0}\" must not be one of the following values: {1}"), // | ||
| OBJECT_ALL_OF("object.allOf", "\"{0}\" must be have of all of the following values: {1}, missing values: {2}"), // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object. prefix is not correct in this case
@making I followed the test case format already present in the same test file. The use case is simply to verify whether all items from one collection are present in an expected collection. For example, consider a person on vacation with a planned list of places to visit. There might be certain locations they definitely want to visit. This type of validation can be useful in such scenarios. |
making
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run ./mvnw spring-javaformat:apply for the code format
|
Thanks for your contribution! |
Adding validation for
allOf