Skip to content

Conversation

@mkoeppe
Copy link

@mkoeppe mkoeppe commented Dec 6, 2025

Portability tests for macOS, Linux, Windows (mingw)

Preview: https://github.com/passagemath/upstream-m4ri/actions/runs/19993649023

@mkoeppe
Copy link
Author

mkoeppe commented Dec 6, 2025

@malb
Copy link
Owner

malb commented Dec 6, 2025

I'm afraid I'm not keen on merging this because it would commit us to supporting these platforms without access to them or experience with them. I don't think I could live up to that commitment.

@mkoeppe
Copy link
Author

mkoeppe commented Dec 6, 2025

This can be mitigated by documenting that this CI is non-normative.

@malb
Copy link
Owner

malb commented Dec 7, 2025

I was, of course, wrong. We already have Windows in our CI and our README already states:

We support M4RI on Linux. Support for Windows (MSYS2/MinGW) and OS X (GCC) is provided on a best effort basis and may disappear any time.

I've merged another PR which adds OSX to our CI (given that Windows already is there, this makes sense).

I think that covers us on platforms and CI. Thanks for the PR, I really do appreciate your efforts to make the whole ecosystem portable!

@malb malb closed this Dec 7, 2025
@mkoeppe
Copy link
Author

mkoeppe commented Dec 7, 2025

No worries, I'll just keep the CI on a branch ci-sage at https://github.com/passagemath/upstream-m4ri for next time.

@malb
Copy link
Owner

malb commented Dec 8, 2025

Thank you <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants