Skip to content

Debugger disassembly view: Restrict coloring of breakpointed instructions to their addresses; add asterisk characters to make breakpointed addresses more conspicuous #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Debugger disassembly view: Restrict coloring of breakpointed instructions to their addresses; add asterisk characters to make breakpointed addresses more conspicuous #14411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/emu/debug/dvdisasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,10 +451,6 @@ void debug_view_disasm::redraw()
if(m_dasm[effrow].m_is_pc)
attrib = DCA_CURRENT;

// if we're on a line with a breakpoint, tag it changed
else if(m_dasm[effrow].m_is_bp)
attrib = DCA_CHANGED;

// if we're on the active column and everything is couth, highlight it
if(m_cursor_visible && effrow == m_cursor.y)
attrib |= DCA_SELECTED;
Expand All @@ -463,7 +459,11 @@ void debug_view_disasm::redraw()
if(m_dasm[effrow].m_is_visited)
attrib |= DCA_VISITED;

print(row, ' ' + m_dasm[effrow].m_tadr, 0, divider1, attrib | DCA_ANCILLARY);
// if we're on a line with a breakpoint, tag it changed
if(m_dasm[effrow].m_is_bp)
print(row, '*' + m_dasm[effrow].m_tadr + '*', 0, divider1, attrib | DCA_CHANGED | DCA_ANCILLARY);
else
print(row, ' ' + m_dasm[effrow].m_tadr, 0, divider1, attrib | DCA_ANCILLARY);
print(row, ' ' + m_dasm[effrow].m_dasm, divider1, divider2, attrib);

if(m_right_column == DASM_RIGHTCOL_RAW || m_right_column == DASM_RIGHTCOL_ENCRYPTED) {
Expand Down
Loading