[pull] master from dropwizard:master #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support mocking the `Logger` when testing `SelfValidatingValidator`. This reduces the amount of stdout noise when running this test (although Hibernate still logs a message)
We can turn off the output from `TestLogger` here, making the test quieter.
…kout-2.x Update actions/checkout action to v2.4.0 (master)
Suppress console output in `dropwizard-validations` tests
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Replace slf4j-test by logback
slf4jtest is no longer used.
Remove old slf4jtest configuration
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Remove jersey-apache-connector
Co-authored-by: Renovate Bot <bot@renovateapp.com>
… v3.9.1.2184 (#4411) Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Fix `BadLogTest`
…ows (#4423) When executing the tests on Windows with Java 11, a `SocketTimeoutException` is thrown in a test of `dropwizard-health` instead of a `ConnectException`. However, the test completes successfully when running with Java 17 or when running the test on Linux. Since the framework will probably support Java 11 for quite some time, the test should succeed on Windows. Therefore the test is modified to allow both exception types.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Remove `public` modifiers from nested test classes and test methods
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
…-plugin to v3.2.2 (#4825) Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
…v1.6.12 (#4806) Co-authored-by: Renovate Bot <bot@renovateapp.com>
This module's code is already test code. Don't report on test coverage for it.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Not everything needs both a start and stop method. Provide default no-op implementations.
Add default methods to dropwizard-lifecycle's `Managed` interface
This test didn't assert anything, which made Sonar unhappy.
Classes with names matching *Test but which don't contain any tests make Sonar unhappy.
This abstract class didn't have any abstract methods and all its methods can be static. Turn it into a class of static helper methods. The static initialiser which unregistered `AddColumnGeneratorSQLite.class` no longer seems to be necessary (added in fe842d2 in 2018 as part of the Liquibase 3.6.0 upgrade)
Address Sonar warnings in tests
…ad-artifact-3.x Update actions/upload-artifact action to v3 (master)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* Deprecate ByteStreams, ready for Dropwizard 3.0 Dropwizard 3.0 will drop support for Java 8 and this class will no longer be necessary. Mark it as deprecated now, to give users some notice. * Deprecate Maps, ready for Dropwizard 3.0 Dropwizard 3.0 will drop support for Java 8 and this class will no longer be necessary. Mark it as deprecated now, to give users some notice.
This was scheduled for removal in Dropwizard 2.1.0
Remove NonblockingServletHolder
Instead of using our own `ResourceHelpers` class, since `SslContextFactory` is a jetty util class, use the Jetty util class `Resource` to load our test truststore from the classpath. This reduces our usage of `ResourceHelpers` to be obtaining absolute paths to files in order to supply config overrides or to pass to `Application#run()`
Dropwizard 3.0 will drop support for Java 8 and this class will no longer be necessary. Mark it as deprecated now, to give users some notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )