Fix crash when objects are pulled with the gravity gun#359
Merged
Blixibon merged 1 commit intomapbase-source:masterfrom Jan 18, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash introduced with the latest update. Upon pulling an object with the gravity gun, the game would crash.
The issue was introduced with #266 and was due to the
dynamic_castseen here. The problem with thisdynamic_castwas that it casted topObjinstead ofpEntity.pObjrefers topEntity's physics object, rather than the entity itself. With this PR, I confirmed that the crash is resolved and the new output functions properly.This resolves #358.
As a hotfix branch, this will be rebased directly into
master. Please do not pull from this branch independently.