Add getNeighbors() and tilesToFeatureCollection()#40
Add getNeighbors() and tilesToFeatureCollection()#40douglasg14b wants to merge 5 commits intomapbox:mainfrom
Conversation
|
👍 |
| const z = tile[2]; | ||
|
|
||
| return [ | ||
| [x - 1, y - 1, z], // NW |
There was a problem hiding this comment.
it doesn't check for valid tiles.
what about [-1, -1, 3]
There was a problem hiding this comment.
It's been quite some time since I touched this and I've lost all familiarity. Do you already have a function that checks for valid tiles? If not, can you define what such a check might look like?
There was a problem hiding this comment.
If I remember correctly many other functions don't perform these checks (I assume for performance reasons), Is there a reason this function is special in that regard?
mrnix
left a comment
mrnix
left a comment
There was a problem hiding this comment.
Looks good, you should add a checks for valid tiles
|
@mrnix Update on this PR & review? |
|
@mrnix ? |
|
Apparently I have to submit a review completely to comment on a review on github? Hopefully my comments are visible now... |
2 participants
Not sure how to do two different pull request for two different things, but this request is dependent on #39
Adds two new methods:
getNeighbors()tilesToFeatureCollection()Let me know if these are additions you are willing to accept, hopefully these are not gratuitous.