Add new burial diagnostics#486
Open
mnlevy1981 wants to merge 3 commits intomarbl-ecosys:developmentfrom
Open
Conversation
Always compute the derivative of the burial for POC, POP, and bSi with respect to that particle's burial coefficient; we want to make it available in diagnostic output regardless of value of ladjust_bury_coeff
d_POC_bury_d_bury_coeff, d_POC_bury_d_bury_coeff, and d_POC_bury_d_bury_coeff are now available diagnostics, stored in store_diagnostics_particulates()
Default is to not include the three new variables, but they are available for users to turn on if desired
Collaborator
Author
|
I expect some regression test failures because these new diagnostics are not included in the baselines for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three derivatives used to compute burial coefficients when
ladjust_bury_coeff = .true.are now available as diagnostics regardless of the value ofladjust_bury_coeff. They are not included in the default diagnostic set but will be useful for computing the burial coefficients offline for GCMs that do not provide the global operators necessary to adjust the burial coefficients on the fly.