Skip to content
This repository was archived by the owner on Jul 6, 2020. It is now read-only.

Update for better customize http codes#20

Open
djdaca wants to merge 7 commits intomarcj:masterfrom
djdaca:master
Open

Update for better customize http codes#20
djdaca wants to merge 7 commits intomarcj:masterfrom
djdaca:master

Conversation

@djdaca
Copy link

@djdaca djdaca commented Oct 2, 2014

This is veary good library ( sorry for my worst english )

This changes is for people who want customize http codes in his api more info in my commits.

djdaca added 2 commits October 2, 2014 17:52
I cannot choice in class for httpStatus - can send only 200,400 and 500 and its little :(
required parameters must be before optional parameters.
@djdaca
Copy link
Author

djdaca commented Oct 2, 2014

Hey ! in $statusCodes in Client class you forget on 418 status 'I'm a teapot' :)))

@marcj
Copy link
Owner

marcj commented Oct 2, 2014

Seems it broke the test suite:

Declaration of RestService\InternalClient::sendResponse() should be compatible with that of RestService\Client::sendResponse() in /home/travis/build/marcj/php-rest-service/RestService/InternalClient.php on line 24

@djdaca
Copy link
Author

djdaca commented Oct 2, 2014

Thanx for reply: i edited it on github web and my commit is only ilustration but i can repair it deeply :) sorry for it

@djdaca
Copy link
Author

djdaca commented Oct 2, 2014

fixed - i hope

@marcj
Copy link
Owner

marcj commented Oct 2, 2014

Still :p
You need to adjust also this method here according to the php error message:
https://github.com/marcj/php-rest-service/blob/master/RestService/InternalClient.php#L13

required parameters must be before optional parameters.
@djdaca
Copy link
Author

djdaca commented Oct 3, 2014

Ufff iam so stupid - thanx

Customize http codes for sendError and sendBadRequest
Parsing phpInput from content_type
Parsing available from: json string and url string
@djdaca
Copy link
Author

djdaca commented Oct 3, 2014

It is ok for you ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation.

@marcj
Copy link
Owner

marcj commented Oct 3, 2014

build still fails ...

@marcj marcj closed this Oct 3, 2014
@marcj marcj reopened this Oct 3, 2014
@djdaca
Copy link
Author

djdaca commented Oct 3, 2014

damn - i use tabs and u whitespace - repaired....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants