You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 13, 2021. It is now read-only.
I think this is a nice addition! Although ideally I think this could be considered a global theme setting (I don't see people using both default and simple border in the same application, but I could be wrong. I'm thinking possibly adding a method to the Theme struct (maybe tui.SetBorderStyle(tui.BorderStyleSimple)). Then, instead of checking the border style in each widget, maybe add a new tui.DrawRectangle() to the Painter struct. Since Painter has access to the current theme, you could do the lookup there instead. What do you think?
Before submitting this pr, I thought there were many ways to implement this feature without breaking the original design. One scene that makes me want to use two borders at the same time is that I use tui-go to create a terminal app which has a login page and many forms. The login in example is very pretty, you can display different forms after login. The report uses a simple border to make it look easier.
Making changes in the Painter allows for more flexible functionality and more considerations. Now that I have some good ideas for adding functionality to Painter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widget Grid can use SetSimpleBorder() to set the simple border.
look like:
default