Change RegEx to capture url(‘’) declaration for inline styles. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often use inline styles for things like background-images. This is because the image URL is often defined in a meta field. Easier than generating CSS.
For those use cases, WP Stack CDN does not convert the URLs to CDN URLs.
By removing the equal sign from the RegEx pattern, the pattern works properly with these types of URLs. This is obviously a bit less specific, but it's difficult for me to imagine a scenario where this breaks something.
Edit: I pushed an additional commit that adds SVG to the valid extensions.