Conversation
onMouseOver, onMouseOut and onClick exposed in config to allow for tooltip on label text
|
@jpetitcolas just thought to let you know about the PR with some additional features. I have done this on a few EventDrop charts and then when someone opened an issue I thought it would be handy to include it. Also maybe update the NPM version. I guess the dependencies should maybe be bumped as well? |
fzaninotto
left a comment
There was a problem hiding this comment.
There is already an onMouseOver property on the drop set (see https://github.com/marmelab/EventDrops/blob/master/demo/demo.js#L37 for an example). What can your PR offer that the existing code doesn't allow to do?
|
Reverted the changelog additions. The change from * to - was done by husky and not me. |
|
You want to show a tooltip when a user hovers on a tooltip? I'm not sure I understand. Could you be more specific about a possible use case? |
|
Meant label and not label tooltip, this PR is in response to #272 so if you have a look at that you will see what the intuition behind it is. It exposes the |
Exposed
onMouseOver,onMouseOutandonClickevents to the config. This allows adding tooltip for label quite easily.Might include an example of this once I got time or maybe modifying the existing Demo to showcase this?
Edit*
Closes #272