Big rework to match retail functionality#6
Big rework to match retail functionality#6laytya wants to merge 22 commits intomartinjlowm:masterfrom
Conversation
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Introduced animation:SetTarget() - Sets the region affected by this animation Reworked saved attributes per animation from per group Added: - startdelay & enddelay functionality - Get/SetSmoothProgress - to use custom function of smothprogress - 'OnStep' (temporary name) callback, fires every OnUpdate of animation - 'REPEAT' type of looping Fixed many mistakes. Fixed 'OnLoop' callback
There was a problem hiding this comment.
A number of comments - good to see you've got some linting going :)
However, I'd prefer to see feature-based PRs. That makes it a bit easier to review.
It seems like you are working hard on getting feature parity - if you are up for it and have a bit of TypeScript experience, I can highly recommend migrating this codebase to https://typescripttolua.github.io/ - typeless languages are a pain when their project grows...
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
|
I can do feature PR but you have not much time to review - and git stucking it in huge PR =))) |
Co-authored-by: Martin Jesper Low Madsen <martin@martinjlowm.dk>
and removed work comments some naming
|
Reworked =) |
martinjlowm
left a comment
martinjlowm
left a comment
There was a problem hiding this comment.
Some simplification thoughts.
|
I did your version w/ some corrections from tests |
2 participants
No description provided.