Discuss: Improved Async, DataProvider support (TiVo Contributions)#161
Closed
jgranick wants to merge 12 commits intomassive-oss:masterfrom
Closed
Discuss: Improved Async, DataProvider support (TiVo Contributions)#161jgranick wants to merge 12 commits intomassive-oss:masterfrom
jgranick wants to merge 12 commits intomassive-oss:masterfrom
Conversation
TestClassHelper - added support for multiple before/after/beforeclass/afterclass methods called in proper inheritance order, support for dataprovider annotation TestResult - added support for optional arguments passed via dataprovider TestRunner - reworked async support to not require a parameter to the function by making the active runner a static. if 'nme' is defined, made tests run without blocking so that nme can process the main loop. various changes to support multiple before/after methods. various fixes to async test handling, including calling async timeout handler. AsyncDelegate, AsyncFactory - added timeout handler support PrintClientBase - improved error reporting TestClassHelperTest, TestClassStub - added unit tests for multiple before/after method annotations being called in proper inheritance order. UnexpectedAsyncDelegateException - new exception for unexpected async requests Async - new global class for making Async requests TestClassStubSuper - unit test class for testing super class before/after annotations.
1. TestRunner.hx : has these enhancements,
a) chained async test support
b) simultaneous multiple async test support
c) allowing exceptions to occur in @BeforeClass, @afterclass, @before, @after methods
2. TestClassHelper.hx : Fix: allows static scoped data providers
3. AsyncDelegate.hx : Fix: does not call time-out handler if the async test is already cancelled
4. New files:
a) ChainedAsyncTest.hx - unit tests for 1(a)
b) ParallelAsyncTest.hx - unit tests for 1(b)
c) PrePostActionAssertsTest.hx - unit tests for 1(c)
d) DataProviderTest.hx - unit tests for data provider feature
has an hamcrest matcher that should probably go into hamcrest repo
e) DataProviderUsageExample.hx - just an example source for data provider usage
5. TestSuite.hx - updated suite to include 4(a), 4(b), 4(c), 4(d)
6. All other files - Renamed Async.asyncHandler to Async.handler, or removed unapplicable copyright
7. Removed haxelib.json
…f upstream branch
Contributor
|
There won't be a munit 2. This project was shelved a while ago and instead this library has been significantly cleaned up relatively recently and I'd welcome further improvements, provided it doesn't cause serious API changes. |
Contributor
|
@SlavaRa what do you think? |
Contributor
Author
|
I'm open to looking at migrating the async syntax back (to avoid API changes), though trying to think of the advantages of the static approach, apart from keeping the function parameters clean. |
jgranick
added a commit
to jgranick/MassiveUnit
that referenced
this pull request
Apr 4, 2019
Contributor
Author
|
Closed in favor of: #164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this pull to help start a discussion around the TiVo contributions.
In our use of munit, we've reached the point (on the OpenFL team) of wanting data provider support, and (more importantly) requiring better async testing. The changes made by the TiVo lead to proper asynchronous testing within Lime and OpenFL, which is a huge plus to us.
There are two issues that I believe led to the proposal being frozen:
1.) It changes the signature of asynchronous test methods to not require a
factoryparameter.2.) It's old, and didn't merge properly anymore
We could ask @sganapavarapu1 about all the reasons behind the API change, but at first guess, I would say that this might fix timing for when asynchronous methods are called, or makes it easy to quickly
@AsyncTesta method.(EDIT: Oh, I see the DataProvider support, perhaps the async factory parameter also muddies how data providers work, if you mixed it with async: https://github.com/sganapavarapu1/MassiveUnit/blob/master/test/massive/munit/DataProviderTest.hx#L65-L85)
Regardless, this raises another question about munit. The comments mentioned "munit 2 being released," but I'm not sure if we can expect this to occur. Is "munit 2" a reality? Would it be possible to work as a community to finish or improve this unreleased version?
Otherwise, could we consider whether this (or other) breaking changes make sense?
Thank you guys