Open
Conversation
AlexHaxe
reviewed
May 13, 2023
|
|
||
| - Removed `EDisplayNew` which is now removed in Haxe 4.3 | ||
| - Moved `haxelib.json` to the root of the repository, so that it can be added as a git haxelib dependency | ||
| - Replaced the deprecated `@:extern` metadata with the `extern` keyword |
Contributor
There was a problem hiding this comment.
should also mention dropped support for Haxe 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change I'd like to contribute is the moving of
haxelib.jsonto the project root and specifying theclassPath, since this way it can be added as a haxelib git dependency.Some other minor changes in this PR are replacing the deprecated
@:externmetadata and updatingCHANGES.md.