Location targetting functions added (but still a work in progress)#2
Open
lukaso wants to merge 3 commits intomasuidrive:masterfrom
Open
Location targetting functions added (but still a work in progress)#2lukaso wants to merge 3 commits intomasuidrive:masterfrom
lukaso wants to merge 3 commits intomasuidrive:masterfrom
Conversation
…llow ads to be better targetted if set. Current version does not crash, but not sure if correct values are sent for date.
Added location variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Yuichiro,
I've added code to this fork to work with the location parameters. But it's not exactly tested.
I know it compiles, and it doesn't crash. What I don't know is if it sends location information to AdMob. Also, I don't know if it does the right thing if no location information is provided (I haven't been able to find reliable info on the web.
I thought I'd send you the request in case you thought it was helpful, or if you had further suggestions.
Thanks for creating the module in the first place, and open sourcing it!
Regards,
-Lukas