Skip to content

Fixed PriceLevelDeleteMessage Side property is not initialized #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed PriceLevelDeleteMessage Side property is not initialized #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/IQFeed.CSharpApiClient.Tests/Streaming/Level2/Messages/Level2MessageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void Should_Parse_PriceLevelUpdateSummaryMessage_Culture_Independent(stri
}

[Test, TestCaseSource(typeof(CultureNameTestCase), nameof(CultureNameTestCase.CultureNames))]
public void Should_Parse_PriceLevelDeleteMessage_Culture_Independent(string cultureName)
public void Should_Parse_PriceLevelDeleteMessage_Ask_Culture_Independent(string cultureName)
{
// Arrange
TestHelper.SetThreadCulture(cultureName);
Expand All @@ -104,5 +104,22 @@ public void Should_Parse_PriceLevelDeleteMessage_Culture_Independent(string cult
Assert.AreEqual(priceLevelDeleteMessageParsed, priceLevelDeleteMessage);
}

[Test, TestCaseSource(typeof(CultureNameTestCase), nameof(CultureNameTestCase.CultureNames))]
public void Should_Parse_PriceLevelDeleteMessage_Bid_Culture_Independent(string cultureName)
{
// Arrange
TestHelper.SetThreadCulture(cultureName);
var priceLevelDeleteMessageString = "9,@ESM19,B,2938.25,20:31:04.876740,2019-04-23,";

// Act
var priceLevelDeleteMessageParsed = PriceLevelDeleteMessage.Parse(priceLevelDeleteMessageString);
TimeSpan.TryParseExact("20:31:04.876740", PriceLevelDeleteMessage.UpdateMessageTimeFormat, CultureInfo.InvariantCulture, TimeSpanStyles.None, out var time);
DateTime.TryParseExact("2019-04-23", PriceLevelDeleteMessage.UpdateMessageDateFormat, CultureInfo.InvariantCulture, DateTimeStyles.None, out var date);
var priceLevelDeleteMessage = new PriceLevelDeleteMessage(Level2MessageType.PriceLevelDelete, "@ESM19", Level2Side.Buy, 2938.25, time, date);

// Assert
Assert.AreEqual(priceLevelDeleteMessageParsed, priceLevelDeleteMessage);
}

}
}
2 changes: 1 addition & 1 deletion src/IQFeed.CSharpApiClient/Streaming/Level2/Messages/PriceLevelDeleteMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public PriceLevelDeleteMessage(
{
MessageType = messageType;
Symbol = symbol;
Side = Side;
Side = side;
Price = price;
Time = time;
Date = date;
Expand Down