Skip to content

Conversation

@mathuo
Copy link
Owner

@mathuo mathuo commented Dec 1, 2025

Resolves issue #1032 where group activation clicks stop working after calling addPanel from within panel content (e.g., button clicks).

The problem occurred when:

  1. User clicks button in Panel A to add Panel B
  2. DOM focus stays on Panel A but Panel B becomes active programmatically
  3. FocusTracker thinks Panel A still has focus
  4. Subsequent clicks on Panel A's group don't fire focus events
  5. No focus event = no group activation

Solution:

  • Add refreshFocusState() method to ContentContainer
  • Call refreshState() on FocusTracker after programmatic panel activation
  • Ensures FocusTracker state stays synchronized with actual active panel

🤖 Generated with Claude Code

Resolves issue #1032 where group activation clicks stop working after
calling addPanel from within panel content (e.g., button clicks).

The problem occurred when:
1. User clicks button in Panel A to add Panel B
2. DOM focus stays on Panel A but Panel B becomes active programmatically
3. FocusTracker thinks Panel A still has focus
4. Subsequent clicks on Panel A's group don't fire focus events
5. No focus event = no group activation

Solution:
- Add refreshFocusState() method to ContentContainer
- Call refreshState() on FocusTracker after programmatic panel activation
- Ensures FocusTracker state stays synchronized with actual active panel

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@mathuo mathuo linked an issue Dec 1, 2025 that may be closed by this pull request
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 1, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc1d9be:

Sandbox Source
dockview-app Configuration
editor-gridview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
nativeapp-dockview Configuration
rendering-dockview Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

addPanel/removePanel breaks the active group update

2 participants